chore: testrunner setup #26
Conversation
| expect, | ||
| skip: (reason) => { | ||
| test.skip(reason); | ||
| }, |
There was a problem hiding this comment.
@niklashaug Does it make sense to pass skip here? Afaik skip needs to be called before the test is executed. But maybe that's a special feature of the node test runner (which I haven't used yet).
There was a problem hiding this comment.
The node test runner supports skipping a test while being run: https://nodejs.org/api/test.html#skipping-tests
I just had a look, Jest for example doesn't seem to support it.
What I could do is, do the check whether the test should be skipped before returning inside of the map function, so that any test I want to skip is just not returned and therefore will not be run at all.
There was a problem hiding this comment.
Makes sense. It depends on whether you want to show to the user that there is a test but it is skipped (for whatever reason).
There was a problem hiding this comment.
I just thought about it again and noticed that this would mean that I'd have to execute parts of the test inside of the generateTestCases() function. But the main purpose of this function and the according method for the consumer should be to return the test cases which should be executed in a later step.
So I'll probably call skip if skip is defined and otherwise just let the test pass and additionally print out a warning or something similar.
# Conflicts: # src/api/index.ts # src/core/policy/policy-decision-point.ts # src/core/tests/runner/node-test-runner.ts # src/core/tests/runner/test-runner.ts # src/core/tests/test-executor.ts # src/core/tests/testcase-generator.ts # tests/mock-server.ts # tests/unit/test-executor.spec.ts
2 participants
closes #22